9 ms·
Similar tactics work when reviewing code. On a scale from least to most effective: 1. "I don't like how this is coded." 2. "[#1]… because it can result in X
by colanderman 13y ago
Similar tactics work when reviewing code. On a scale from least to most effective:
1. "I don't like how this is coded."
2. "[#1]… because it can result in X happening under circumstance Y."
3. "[#2]… Alternatively, structure the code as A or B."
4. "[#3]… Here are code snippets implementing the change."
Almost no action will occur as a result of #1. However, #4 leaves no excuse but hubris on the part of the reviewee not to accept the modifications (obviously assuming they correct the issue and do not introduce new problems!).