3 ms·
This looks nice, but doesn't address my main complaint with the conversation/PR system: there's no way to batch comments. When doing code reviews, you can some
by necubi 13y ago
This looks nice, but doesn't address my main complaint with the conversation/PR system: there's no way to batch comments.
When doing code reviews, you can sometimes have upwards of 10 or 15 comments. In the current system this means 10 or 15 emails in everybody's inbox. It's also hard to work through a PR without letting everybody know when you're actually finished.
I would love to be able to comment on things as I read through them, then after I finish publish all of the changes and have them go out as one email.
- Touche 13y agoI don't get any such emails. Maybe I turned it off years ago and forgot about it. Anyways, I wouldn't let an optional setting influence the way you work.
- necubi 13y agoTo be clear, I find the emails very useful (this is primarily from the perspective of me using Github for work--it's nice to know when somebody has reviewed your code). But I want one, not 15, and after the code reviewer has finished.
- kisielk 13y agoI agree this is a big problem. I've had cases where I'm still reviewing stuff but the person whose code was under review just fixed my first few comments and then submitted it while I was still writing the rest. I know this is partially a process problem, but having batched emails would certainly help make it more obvious. Google's reitveld is a bit of a mess but at least it gets this part right.
- shurcooL 13y agoCan't you turn off emails but still have GitHub notifications on the website?
- rob 13y agoYou can. I had to do this because my GitHub username (like my HN one) is just my name ("rob") and I was getting notifications from people using @rob in their comments/replies instead of the person's actual GitHub username. :)
- Bockit 13y agoOn the topic of github emails, I'd love the ability to set an email for notifications on a per repository, instead of just per organisation basis.
- Newky 13y agoAnother advantage to this system is that reading and commenting becomes less prone to these sort of comments: "Where is X defined" "Ah I see, this is where X is defined, disregard older comment" A publish system allows you to basically stage comments before publishing. I used rietveld before github and this alongside side by side diffs was killer.
- JoshTriplett 13y agoSounds like you want something closer to Gerrit, where you can do line-by-line code reviews on an entire commit along with an overall comment, and the whole thing goes out as one mail.
- welder 13y agoI found a :thumbsup: emoticon comment successfully tells everyone I'm finished reviewing a pull request.
- spicyj 13y agoLikewise. I find myself reluctant to comment on minor problems because I don't want to send another email. We use http://phabricator.org/ http://phabricator.org/ at work and I absolutely love it, but sometimes I'm forced to use GitHub for things and I get sad.