4 ms·
Goodness. I haven't read a pull request discussion like that since the semicolon battle in Bootstrap (https://github.com/twbs/bootstrap/issues/3057 https://gith
by jonknee 13y ago
Goodness. I haven't read a pull request discussion like that since the semicolon battle in Bootstrap (https://github.com/twbs/bootstrap/issues/3057 https://github.com/twbs/bootstrap/issues/3057). At least the semi-colon pull request actually fixed something.
- Pxtl 13y ago... long discussion is long, but now I'm curious - did somebody eventually cave? Or did the offending line of code get reformatted into the appropriate if-statement since using the shortcircuiting behavior of javascript "and" as a naked flow-control construct seems obscene.
- dllthomas 13y agoSome people like obscenity.
- swang 13y agoRead fat's first post. The code was already changed but fat was purposely trolling.
- jonknee 13y agoBootstrap is still semi-colon free. I really don't like the style personally, but I'm not about to start a flame war. https://github.com/twbs/bootstrap/blob/master/js/dropdown.js https://github.com/twbs/bootstrap/blob/master/js/dropdown.js