4 ms·
What do people think of the OP's test repo? https://github.com/donnfelker/example-rails-challenge https://github.com/donnfelker/example-rails-challenge This i
by danso 13y ago
What do people think of the OP's test repo?
https://github.com/donnfelker/example-rails-challenge https://github.com/donnfelker/example-rails-challenge
This is a sensible test, I guess, but the OP is just satisfied that the devs know basic syntax and conventions? Would it be more productive to ask more open-ended questions...such as, instead of telling exactly what tests they should write, ask them to write tests that verify the system is working.
Hell even if they did it in Minitest, that ability to conceptually prove how systems in Rails work would seem more valuable than knowing RSpec convention
- donnfelker 13y agoYou could totally do this. I think variation like this are great. I do this all the time. Depends on the type of developer I'm after. I've had advanced challenges/etc. One of my best hires went above and beyond my requirements and stated (in the pull request) that we could do X, Y and Z to improve the code and test coverage. I hired them and they helped me launch a product. But I agree, you can do exactly what you said. Feel free to take this and change it up. :)
- seivan 13y agoMiniTest has 'rspec syntax' with 99% less dirty fucking hacks.
- tonyarkles 13y agoPersonally, I'd probably do it more like the author did. Not that Minitest (or others) is better or worse than RSpec, but rather RSpec is what I have experience with and if I were going to take over the project for whatever reason, I'd much rather have things already in the state I'm familiar with.