4 ms·
> and anyway Mozilla committers regularly check in code which doesn't match the reviewed code How does that work? Are reviews optional?
by xtrumanx 13y ago
> and anyway Mozilla committers regularly check in code which doesn't match the reviewed code
How does that work? Are reviews optional?
- BrendanEich 13y agoReviews are required, but we don't have automation to test integrity and authenticity. Mostly the diffs between what is reviewed and what is pushed are cosmetics that the reviewer asked for and pre-r+'ed without wanting another patch in a bug, but there's room for mischief. People do watch bugs and repos and catch stuff. We are working on making the system more foolproof, as part of a larger effort to move all our CI infra (save Mac, sigh) to the cloud and our release engineering to a devops model.
- reubenmorais 13y ago>(save Mac, sigh) Bug 921040 [0] seems to be progressing, even if slowly. https://bugzilla.mozilla.org/show_bug.cgi?id=921040 https://bugzilla.mozilla.org/show_bug.cgi?id=921040
- BrendanEich 13y agoYeah, I am not holding my breath. If the tremendous effort there pays off and Apple doesn't screw us later, yay. /be
- samth 13y agoIt works because a reviewer will say "here are a bunch of comments, the patch is approved once these are fixed". It's a very reasonable thing to say when the comments are minor (such a style issues) and the reviewer and coder trust each other.