2 ms·
Useful patches for OpenSSH represent a competitive advantage that other companies do not have. True. However, they also result in additional costs -- you may
by cperciva 17y ago
Useful patches for OpenSSH represent a competitive advantage that other companies do not have.
True. However, they also result in additional costs -- you may have to rewrite your patches when new versions of OpenSSH are released, you will have additional system administration costs (you won't be able to use precompiled OpenSSH binaries), and you may have additional training costs (it's easy to find a sysadmin who knows how to use OpenSSH; not so easy to find someone who knows how to use OpenSSH-plus-your-local-patches).
Even worse, there's a risk -- and I've seen this happen to many companies -- that whoever wrote your patches originally will leave the company, and you'll be stuck wanting to update to a newer OpenSSH but without the expertise needed to merge your patches.
I'm not saying that it's always to your advantage to contribute patches back -- but I think in most cases the costs of keeping your own patches outweigh any competitive advantage they may give you.
- tsally 17y agoGood point, I had never thought about it quite that in depth before. However, I am still willing to contend that large companies who can afford the staff do (or should) have large internal patch sets for OpenSSH, FreeBSD, etc. You can be sure the NSA does. ;-)
- cperciva 17y agoI am still willing to contend that large companies who can afford the staff do (or should) have large internal patch sets for OpenSSH, FreeBSD, etc. This absolutely happens -- I know of lots of companies which do this, for a wide variety of reasons. Some companies have local patches which aren't contributed back because they simply aren't relevant to the community at large; for example, I know of one large FreeBSD-using company which at one point had if (strcmp(fname, "mysql")) { /* Handle mysql processes specially */ ... } blocks in their kernel. Other companies have local patches simply because they're not sure exactly how to go about contributing changes back -- either due to a lack of knowledge about open source in general, or because they started with a source tree and started hacking, and aren't sure exactly what they've changed. I've seen job postings with "get the changes we've been making locally for the past five years into the FreeBSD tree" high on the list of job responsibilities. And then, of course, you're right that there are some companies which have changes which they could contribute back, but choose not to. But based on the companies I've talked to (which, admittedly, is a biassed sample), this doesn't seem to be a very common scenario.