3 ms·
We have very few automated tests. He could have just written that one sentence.
by stcredzero 13y ago
We have very few automated tests.
He could have just written that one sentence.
- nobodyshere 13y agoBeen there. Can confirm.
- rgalanakis 13y agoI changed it to "relatively few." We actually have several thousand altogether, but we have a lot of code. I don't want to discourage the great progress we've made.
- stcredzero 13y agoI understand your position. I've managed a group that was struggling to increase test coverage. It's hard to make testing work if management wasn't behind it from the get-go. Short term thinking almost ensures this doesn't happen. It is possible to catch up, however. A friend of mine did it with a DoD project. (In C++!)
- aredington 13y agoThe core point is the same: With sufficient test coverage, you can change one variable (Python 3 vs 2) and control for all others. Tests are not an end, they are a means to an end; the courage to change your software in the face of a constantly changing world. Sounds like you're not there, but maybe you have specific domains of EVE that you feel comfortable changing at your whim. That's the success to focus on.
- logicallee 13y ago>With sufficient test coverage, you can change one variable (Python 3 vs 2) That is a pretty hilarious way of putting it.
- mitchty 13y agoSomewhat naive too to be honest. As someone that had just plain old ruby circa 1.8.5ish code (not rails) that I ported to 1.9 a while back, even with tests there were differences in behavior that I guarantee you probably weren't thinking of writing a unit test for. Unit tests are nice, but they don't make things braindead easy. Just make it a bit easier to narrow down where something might be broken/different.
- MartinCron 13y agoWith sufficient test coverage, you can change one variable (Python 3 vs 2) and control for all others The safest change to make is the smallest change possible, after all.
- raylu 13y agoThat's quite a glorified view of tests. You can have the best test coverage in the world backed by a great CI culture but if porting something is a huge time investment, it may still be a huge time investment. Maybe there's one 2.x feature that you use almost everywhere that has been removed in 3.x and there's no simple way to replace it automatically.
- lotyrin 13y agoYeah, but if you have a test suite you add Python 3 and silence the existing failures. Now you can (at least partially) avoid writing new code that wouldn't work on 3, as well as gain the option of refactoring things to resolve compatibility - with lots of freedom to decide how much effort to spend on that if any. It'd no longer be a huge risky project where you have to cut the QA team over to Python 3, then spend a bunch of QA's time putting the new code through the ropes with no end in site while explaining to management that this is all providing zero new functionality.
- raylu 13y agoYeah, but if you have a test suite you add Python 3 and silence the existing failures. They likely already know where a lot of their failures are going to be even without tests. The effort involved in fixing those known failures alone is prohibitive. The fact that the rest of regression testing will be easier with tests is nice, but doesn't reduce the work required to a level where they can justify doing it. Now you can (at least partially) avoid writing new code that wouldn't work on 3, Once you're on 3, you can just run your code and see if it works on 3. You don't need tests to avoid writing code that works on 2 but not 3. as well as gain the option of refactoring things to resolve compatibility - with lots of freedom to decide how much effort to spend on that if any. I don't think resolving compatibility issues is optional...
- lotyrin 13y ago> I don't think resolving compatibility issues is optional... It is if you stay on 2 for production/qa and the bulk of new feature development in the meantime. Only CI (and any developers working on python 3 compat.) would be running 3 and only to provide reports of how compatible things are. Only once the test suite passes would you swap QA to 3, start removing 2 compatibility code (i.e. whatever you've done to hack around handling strings) and eventually ship 3 to production. Edit: The solution of "just switch to 3 then make it work" is exactly what they can't do because of (completely valid) business and political concerns. I think that if they were able to have a goal of some small percent of test progress on Python 3 per release - but continue to ship features - they would be able to find time to do the work if it's at all a priority, even if it took many many releases. If it's not at all a priority then maybe that's the one-sentence summary instead.