4 ms·
> "Our code base has grown organically and its internal dependencies are very complex." That's a polite way of saying "we write shitty code without any sort of
by moron4hire 13y ago
> "Our code base has grown organically and its internal dependencies are very complex."
That's a polite way of saying "we write shitty code without any sort of plan."
> "Splitting it up would make large, atomic refactorings more difficult"
Actually, it's the other way around. Modularity tends to obviate the need for large, atomic refactorings.
And what, exactly, is the meaning of these graphs? This is leading me to believe that being a developer at Facebook is about quantity over quality.
- ZenoArrow 13y agoTo be honest, whilst we have no way to accurately determine whether the code is a mess without a chance to see it, the most surprising line of this article (in my opinion) was that the code base was larger than the Linux kernel. I'm not seeing anything on the front end that would warrant such complexity, guessing a large chunk of the code base is server code. Would be interested in reading a summary of the components of the Facebook code base.
- plorkyeran 13y agoI suspect that the kernel is one of the only things running on Facebook's servers that they didn't write from scratch. Alexandrescu has mentioned that a 1% speedup to HHVM saves FB about $100k per year, and at that sort of scale it's pretty easy for reinventing every wheel to make sense.
- moron4hire 13y agoright, so why can't projects like that exiat in their own repository? what keeps HHVM and Facebook tightly coupled?
- pydave 13y agoSome of them are. > We already have some of the easily separable projects in separate repositories, like HPHP http://article.gmane.org/gmane.comp.version-control.git/189784 http://article.gmane.org/gmane.comp.version-control.git/1897... Presumably some parts aren't so isolated.
- igravious 13y agoThis rather surprised me as well. I tend to think of the Linux kernel as one of the larger single code-bases out there. Am I wrong?
- bpicolo 13y agoIt's one of the largest open source projects perhaps. But when you get into a large company like facebook who creates a hell of a lot of different things the numbers are way higher.
- Crito 13y agoThe kernel is measured in hundreds of megabytes. There are companies with codebases measured in terabytes.
- michal8181 13y agoYes. As described here http://www.informationisbeautiful.net/visualizations/million-lines-of-code/ http://www.informationisbeautiful.net/visualizations/million... Facebook code base (~60 MLOC) if almost 4 times bigger than Linux 3.1 (a mere 15 MLOC).
- enneff 13y ago> Modularity tends to obviate the need for large, atomic refactorings. "Tends to". But when you're dealing with code at Facebook's scale, things that "tend not to happen" actually happen quite a lot. In fact, you must plan for them as a matter of course. So yes, modularity is great, and I because I'm a nice guy I assume Facebook aren't a pack of idiots and that they're writing nice modular code. But even if that's the case, in an organization of Facebook's size you still need to make widespread, atomic refactorings on a regular basis. I know this from experience, because I work at Google (much larger codebase than Facebook) on a low-level piece of our software stack. We face these issues regularly and while working in a single repo has its drawbacks, it also has real advantages.
- moron4hire 13y agoPerhaps I don't understand the whole situation here. I hear "all of our code is in one repository" and I think "GMail and Google Maps are in the same repository, in the same repository with GoLang, in the same repository with AdWords." The more I think about it, the more I think your post reveals a lack of maturity in our industry that lends credence to the pro-engineering-licensing argument that I've argued against many times on my own. That everyone can be so cavalier about this topic. Because the fact that your companies are so large is EXACTLY why it makes no flipping sense that you're running gigantorepository. You have so many products, so many projects going on, that I just really have a hard time believing that it was disciplined software development that led to all of your code being so interdependent. But the part that started getting under my skin was the fact that we aren't talking about Bob's Local Software Consultancy here. We're talking about two companies that touch the lives of hundreds of millions, perhaps even billions of people in the world. If OpenStreetMap doesn't have their code in the same repository as Postgres, Linux, and DuckDuckGo, then there is no excuse for the Facebook Android App to be in the same repository as HHVM.
- skj 13y agoGo is hosted publicly (on googlecode) and adwords is supersecret or some nonsense and non adwords Googlers can't see it. But gmail and maps...well, they share a lot of code! For instance, they both run on web servers.