3 ms·

Well, I think the answer to your question is complicated. But thanks for that! Are the integration tests not included? No insult, just wondering if they ran.

Well, I think the answer to your question is complicated. But thanks for that! Are the integration tests not included? No insult, just wondering if they ran. It's tough. Docker integration tests currently fail on stock Ubuntu from what I can tell. Trying to figure that one out...

akerl_ 13y ago
Can you clarify which integration tests you're referring to? I'd be happy to run them and provide the output. I ran through the whole process linked from the Github repo (http://docs.docker.io/en/latest/contributing/devenvironment/ http://docs.docker.io/en/latest/contributing/devenvironment/), though I only gist'd step 5
- odonnellryan 13y ago
  http://github.com/dotcloud/docker/integration http://github.com/dotcloud/docker/integration should be the link, thank you!
  - akerl_ 13y ago
    That 404s for me. I did some googling, and am not able to find any tests outside of the ones linked from the contributions guide EDIT: It looks like the integration tests reside here: https://github.com/dotcloud/docker/tree/master/integration https://github.com/dotcloud/docker/tree/master/integration They're called when you run make test, via this chain: https://github.com/dotcloud/docker/blob/master/Makefile https://github.com/dotcloud/docker/blob/master/Makefile https://github.com/dotcloud/docker/blob/master/hack/make.sh https://github.com/dotcloud/docker/blob/master/hack/make.sh https://github.com/dotcloud/docker/blob/master/hack/make/test-integration https://github.com/dotcloud/docker/blob/master/hack/make/tes... It looks like the integration tests may not be running because the AUFS test failed? I manually adjusted the Makefile to run the integration tests anyways, and here's the result: https://gist.github.com/akerl/8251863 https://gist.github.com/akerl/8251863 It appears to have a very unhappy time, primarily because the memory cgroup is not enabled. That was a deliberate choice because from what I can see there is a performance hit for enabling that (as well as the swap cgroup), and we decided to leave that disabled rather than give all users a performance hit in order to benefit docker users.
    - odonnellryan 13y ago
      That's completely understandable. Sorry for not catching the broken link! I don't know what happened there for me doing that. Linode looks like it's in a lot better shape than DO currently. DO has some issues with Docker that prevent it from being very viable. I'll have to give it a try, thanks again for being so diligent with the tests! The information is useful.
shykes 13y ago
Docker integration tests should not fail on an ubuntu system with all the dependencies installed (ubuntu-standard 3.8 kernel, lxc version 0.8, tar, git..), and when using the correct build environment (see http://docs.docker.io/en/latest/contributing/devenvironment/ http://docs.docker.io/en/latest/contributing/devenvironment/) If tests still fail for you would you mind filing an issue? Thanks!
- odonnellryan 13y ago
  I actually did file one! But don't check it out until I install that exact build ;)

akerl_ 13y ago

Can you clarify which integration tests you're referring to? I'd be happy to run them and provide the output. I ran through the whole process linked from the Github repo (http://docs.docker.io/en/latest/contributing/devenvironment/ http://docs.docker.io/en/latest/contributing/devenvironment/), though I only gist'd step 5

odonnellryan 13y ago
http://github.com/dotcloud/docker/integration http://github.com/dotcloud/docker/integration should be the link, thank you!
- akerl_ 13y ago
  That 404s for me. I did some googling, and am not able to find any tests outside of the ones linked from the contributions guide EDIT: It looks like the integration tests reside here: https://github.com/dotcloud/docker/tree/master/integration https://github.com/dotcloud/docker/tree/master/integration They're called when you run make test, via this chain: https://github.com/dotcloud/docker/blob/master/Makefile https://github.com/dotcloud/docker/blob/master/Makefile https://github.com/dotcloud/docker/blob/master/hack/make.sh https://github.com/dotcloud/docker/blob/master/hack/make.sh https://github.com/dotcloud/docker/blob/master/hack/make/test-integration https://github.com/dotcloud/docker/blob/master/hack/make/tes... It looks like the integration tests may not be running because the AUFS test failed? I manually adjusted the Makefile to run the integration tests anyways, and here's the result: https://gist.github.com/akerl/8251863 https://gist.github.com/akerl/8251863 It appears to have a very unhappy time, primarily because the memory cgroup is not enabled. That was a deliberate choice because from what I can see there is a performance hit for enabling that (as well as the swap cgroup), and we decided to leave that disabled rather than give all users a performance hit in order to benefit docker users.
  - odonnellryan 13y ago
    That's completely understandable. Sorry for not catching the broken link! I don't know what happened there for me doing that. Linode looks like it's in a lot better shape than DO currently. DO has some issues with Docker that prevent it from being very viable. I'll have to give it a try, thanks again for being so diligent with the tests! The information is useful.

shykes 13y ago

Docker integration tests should not fail on an ubuntu system with all the dependencies installed (ubuntu-standard 3.8 kernel, lxc version 0.8, tar, git..), and when using the correct build environment (see http://docs.docker.io/en/latest/contributing/devenvironment/ http://docs.docker.io/en/latest/contributing/devenvironment/) If tests still fail for you would you mind filing an issue? Thanks!

odonnellryan 13y ago
I actually did file one! But don't check it out until I install that exact build ;)