3 ms·
Seems like to do a good code review, the reviewer needs to know the scope of the code they're looking at, and where it fits in the big picture. Hell, maybe even
by SheepSlapper 13y ago
Seems like to do a good code review, the reviewer needs to know the scope of the code they're looking at, and where it fits in the big picture. Hell, maybe even the big picture too.
If you outsource code reviews, you lose that perspective and it comes down to "will it compile, and does it look vaguely correct?" which isn't super valuable.
That being said, if you can overcome that problem then the idea becomes a lot more enticing :)
- derwiki 13y agoThat's a good perspective. "will it compile, and does it look vaguely correct?" can still be helpful though. Imagine you're learning Rails, and haven't learned all the idioms yet. Me leaving comments such as "this would be better as a before filter", "try to avoid metaprogramming unless you have to (and you don't have to here)", etc