3 ms·
Oh, I am certain to write code that could be described as "shit" from time to time as well. But for myself, in that situation I try to say, "this is pretty subo
by eric_the_read 13y ago
Oh, I am certain to write code that could be described as "shit" from time to time as well. But for myself, in that situation I try to say, "this is pretty suboptimal, we have better solutions, but not enough time for them right now." as opposed to "yeah, this is kinda shit."
Definitely we don't want developers who are so precious about their code that they can't handle a little criticism, but there are, IMO, better ways and worse ways to deliver that criticism. Think of it like a judge on Iron Chef-- the worst kind of criticism you can give a dish is, "this is terrible". Only slightly less worse is, "this is wonderful!" Ideally, you need reviews like, "This has a bit too much cinnamon, and I think you way overdid the cumin, but overall this is the best shrimp I've had this week."