4 ms·
There aren't any obvious structural errors but two things occur to me. Firstly, JSON serialization is something every platform, including .NET, already has a mu
by acron0 13y ago
There aren't any obvious structural errors but two things occur to me. Firstly, JSON serialization is something every platform, including .NET, already has a multitude of libraries available for so this is 'reinventing the wheel' a bit. Secondly, looking at what it's actually doing, it's plausible the author doesn't even need JSON, as it's simply serializing a list of `id:name` fields. Thirdly, there are plenty of more 'inline' ways of achieving this using `string.Join`. All in all, just very 'novice' code but nothing _incorrect_ about it. IMO.
- pmelendez 13y agoYeah, that's what I thought. I didn't see anything horrible that were obvious, and by horrible I mean laughable just as the other pieces of code in the website.