3 ms·
Why not point out concrete problems with the implementation? We can't stop at the "smells" level of discussion! So, for example, is it hard to understand? Does
by mbrock 13y ago
Why not point out concrete problems with the implementation? We can't stop at the "smells" level of discussion! So, for example, is it hard to understand? Does it perform poorly? Is it difficult to extend?
- Sharlin 13y agoIt depends on the context. The context may make the smell go away; the "smell" is just a heuristic that says that without any additional arguments in its favor, a hundred-case switch usually isn't the cleanest and most maintainable way to implement something.