4 ms·
> the onus is on the submitter to demonstrate that 1) the fix fixes the problem and 2) that it doesn't break anything else. No. The onus is on Reddit's test su
by lectrick 13y ago
> the onus is on the submitter to demonstrate that 1) the fix fixes the problem and 2) that it doesn't break anything else.
No. The onus is on Reddit's test suite which, ostensibly, would cover voting (one of the core features/functionality of the site!) to demonstrate this. Or are you suggesting that he didn't run the full build?
- ryanobjc 13y agoAh yes the tests pass. Now it is time to relax and veg out. Oh wait, the test suite doesnt actually guarantee bug free software? Worse, test suites dont protect you from bugs in the specs? Well I can tell we are going to have a rough night ahead...
- shadowmint 13y agoDid /r2/tests suddenly get a hundred new awesome tests in the last 6 months? It's pretty... bare. Or it was last time I looked. Pull request -> should include tests if relevant ones don't already exist.
- lectrick 13y ago> It's pretty... bare. Or it was last time I looked. Well then, that's running with scissors as far as any modern legit open source project is concerned. That should be the VERY FIRST thing rectified.