3 ms·
I see your point, but I'm not suggesting a general "email first before pull request" policy, which I agree would be a big mistake. I feel like this was actuall
by Lazare 13y ago
I see your point, but I'm not suggesting a general "email first before pull request" policy, which I agree would be a big mistake.
I feel like this was actually a very unusual situation.
- wpietri 13y agoOk. If it's not a policy, then I don't think there's any way you can expect a potential contributor to know that a particular pull request must be preceded by discussion. In which case, I think the burden falls on the person reviewing the requests. In this case, Noordhuis. The submitter did their bit by making a positive change and offering the patch.