5 ms·
You're missing one very important detail: the person issuing the pull request didn't sign a CLA.
by salehenrahman 13y ago
You're missing one very important detail: the person issuing the pull request didn't sign a CLA.
- sneak 13y agoI don't subscribe to the idea of property rights for information, so that detail is irrelevant to me.
- salehenrahman 13y agoIt is irrelevant to you, but not to libuv. All committers must sign a CLA, otherwise, pull requests issued by those that haven't signed the CLA will be rejected. Edit: I might point out all pull requests that only have two lines of grammar change in documentation. Those lines which really don't mean anything to someone who speaks a language with gendered pronouns applied to inanimate objects.
- regularfry 13y agoYes he did. After the PR, before the initial close.