2 ms·
>to reject a pull request that eliminates a gendered pronoun on the principle that pronouns should in fact be gendered would constitute a fireable offense. ...
by gizmo686 13y ago
>to reject a pull request that eliminates a gendered pronoun on the principle that pronouns should in fact be gendered would constitute a fireable offense. ... the insistence that pronouns should in fact be gendered.
So what. The request was rejected on the principle of it being trivial:
> Sorry, not interested in trivial changes like that. [1]
I can find no mention in the discussion of anyone arguing against the change on the grounds that gendered pronouns are preferable.
We can still argue over wheather this is a good reason to reject a pull request. Personally, I think that trivial requests should be accepted if for no other reason than to be welcoming to newcomers who are testing the waters before becoming active. However, accepting pull requests takes time, and one might not want to encourage a community to spam oneself with minor corrections. Furthermore, in this particular example, the proposed changes were grammatically incorrect, as the object itself is the singular "user", while the new pronoun is the plural "they/them". This could easily be resolved by making user plural, or avoiding the pronoun altogether, but this still takes more of the maintainers time.
Notwithstanding that, it seems completely dishonest to frame the original dispute as Ben Noodhuis objecting to removing gendered pronouns on principle.
[1] https://github.com/joyent/libuv/pull/1015#issuecomment-29538615 https://github.com/joyent/libuv/pull/1015#issuecomment-29538...