3 ms·
but apparently ben didn't revert the commit on the basis of its content, he reverted it on the basis of a bad process (lack of review). So we should criticize
by riffraff 13y ago
but apparently ben didn't revert the commit on the basis of its content, he reverted it on the basis of a bad process (lack of review).
So we should criticize "people who don't accept these commits", or "people who revert commits because of bad process", but the case "people who revert these kind of commits" is not valid.
- ben0x539 13y agoHe initially rejected it on the basis of its content, and then reverted it on a basis that didn't hold up to scrutiny, as one the first comments on the revert commit demonstrates. Seems like that meets both your criteria?