3 ms·
I just deleted a sarcastic comment on here making light of the situation- I had judged it from this PR: https://github.com/joyent/libuv/commit/804d40ee14dc0f82c
by woah 13y ago
I just deleted a sarcastic comment on here making light of the situation- I had judged it from this PR: https://github.com/joyent/libuv/commit/804d40ee14dc0f82c482dcc8d1c41c14333fcb48 https://github.com/joyent/libuv/commit/804d40ee14dc0f82c482d...
From that commit it looks like someone simply didn't follow commit protocol and had the commit reverted because of that.
But if we look at the original https://github.com/joyent/libuv/pull/1015#issuecomment-29538615 https://github.com/joyent/libuv/pull/1015#issuecomment-29538..., we see that that it already had been rejected once, which is, IMO, wrong. After seeing that, it looks like it was right for someone to merge it against protocol.
- steveklabnik 13y agoThe very first comment says that it was signed off on https://github.com/joyent/libuv/commit/804d40ee14dc0f82c482dcc8d1c41c14333fcb48#commitcomment-4736897 https://github.com/joyent/libuv/commit/804d40ee14dc0f82c482d...