7 ms·
Throwing some more info here, this is the NaCl whitelist, looks like it was originally added Feb last year [1]. There's a discussion on Chromium Code Reviews he
by mwill 13y ago
Throwing some more info here, this is the NaCl whitelist, looks like it was originally added Feb last year [1].
There's a discussion on Chromium Code Reviews here [2], and an issue on the project itself here [3]
The original commit includes the comment 'We should remove this code when PNaCl ships' which got removed somewhere along the way.
[1] http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/chrome_content_renderer_client.cc?revision=122709 http://src.chromium.org/viewvc/chrome/trunk/src/chrome/rende...
[2] https://codereview.chromium.org/9368046 https://codereview.chromium.org/9368046
[3] https://code.google.com/p/chromium/issues/detail?id=113668 https://code.google.com/p/chromium/issues/detail?id=113668
- leokun 13y agoFrom the bottom of the issue: "Rick Waldron raised some concerns on Twitter (http://goo.gl/xk3CaX http://goo.gl/xk3CaX) so hopefully I can provide a bit more context: We don't enable NaCl on the web at large because we don't want to see a particular instruction set baked into the web. We enable it for apps that are in the Chrome Web Store (even hosted apps which are in the web) because it's a place where over time we can get developers to migrate to PNaCl. For this whitelist, we have similar controls to what we have on the Chrome Web Store, and our goal is to eventually remove the need for it altogether." Seems interesting anyway.
- deleted 13y ago[deleted]
- deleted 13y ago[deleted]
- deleted 13y ago[deleted]
- deleted 13y ago[deleted]
- deleted 13y ago[deleted]
- deleted 13y ago[deleted]
- mtrimpe 13y agoDoes anybody know why (variations on copies of) leokun's comment are automatically marked as dead? The comment seems perfectly valid so I can't figure out why that would happen...
- paulirish 13y agoThere was a brief discussion about this code on Twitter a few weeks back and I asked for extra clarification from engineering. Erik Kay explained on that bug ticket [3] a bit more: "We don't enable NaCl on the web at large because we don't want to see a particular instruction set baked into the web. We enable it for apps that are in the Chrome Web Store (even hosted apps which are in the web) because it's a place where over time we can get developers to migrate to PNaCl. For this whitelist, we have similar controls to what we have on the Chrome Web Store, and our goal is to eventually remove the need for it altogether."
- Zoomla 13y agoI would be curious to find out who removed that comment 'We should remove this code when PNaCl ships'
- smussman 13y agoLooks like it was done in this commit: http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/chrome_content_renderer_client.cc?r1=223318&r2=223618 http://src.chromium.org/viewvc/chrome/trunk/src/chrome/rende...