3 ms·
> It almost sounds like you are advocating a style of code ownership where programmers shouldn't make changes to other's code without talking to them. Talking
by mcv 13y ago
> It almost sounds like you are advocating a style of code ownership where programmers shouldn't make changes to other's code without talking to them.
Talking to the person who wrote the code you want to change is always a good idea. It's not always possible (because the original coder has left the company or something), but if you have the opportunity, use it. You'll learn something.
I do this all the time. Sometimes the answer is: "You're probably right. Change it." and sometimes it's "It's like that because of good reasons X and Y, and we also use this in another project that needs it to do Z." This understanding is very valuable, and can save you a lot of time.
- raganwald 13y agoAnd the really great thing that happens is when someone says, "Yeah, that code is an ugly hack, and please fix it up, but don't forget good reasons X and Y and Z." Then you get to make it batter without regressing, add the proper tests, and document everything properly, all because you spoke to someone first. :-)