3 ms·
It seems odd to see a commit in this day and age with no unit test. When you make a new newkey struct the clean-up callback should be NULL.
by marc_omorain 13y ago
It seems odd to see a commit in this day and age with no unit test. When you make a new newkey struct the clean-up callback should be NULL.
- noselasd 13y agoThat's the fun with C, it would be quite unlikely the malloc call in a unit test for this didn't happen to zero initialize the struct.
- meowface 13y agoYep. You may get different results based on the code path taken, the compiler, and (maybe?) the OS. Most of the time the value at that memory location will probably be a zero byte (or a zero word/dword), but sometimes it may not.
- djmdjm 13y agoWe committed a regression test fix separately.