3 ms·
Wow. That was a pretty stark example of what not to do when checking for integer overflow, and what not to do when reporting a bug.
by rspeer 13y ago
Wow. That was a pretty stark example of what not to do when checking for integer overflow, and what not to do when reporting a bug.
- zaroth 13y agoI think the point is not "this is the best/right way to write the check", but rather, this way of writing the check used to work, and is pervasive, and now it gets optimized away, and that seems like a Bad Thing. The bug report appears to contain a lot of investigative work by the submitter to try to substantiate their claims. I don't have a problem with the back-and-forth, people are allowed to get passionate, especially if they are doing the leg work to try to substantiate their position.
- tempestn 13y agoThere's a difference between passion and just being rude though. Not only is the latter unpleasant, it removes any chance you might have had of convincing anyone of anything. I mean, his third post ended with, "THIS IS NOT A JOKE. FIX THIS! NOW!" Can you imagine anyone reacting positively to that?