4 ms·

"SURESH PALDIA" likes to get his name into every block of JS code. Ref: https://kyenroll.ky.gov/Scripts/HBECommonUtility.js https://kyenroll.ky.gov/Scripts/HBEC

by semerda 13y ago

"SURESH PALDIA" likes to get his name into every block of JS code. Ref: https://kyenroll.ky.gov/Scripts/HBECommonUtility.js https://kyenroll.ky.gov/Scripts/HBECommonUtility.js Seems to be a common pattern with these gov websites or maybe the outsourcer. Bad quality code! Really really bad JS code chaining everything to the global prototype, hoisting issues indicate low comprehension about JS, no basic minification or cdn use et al.. awful. I hope they didn't spend in the millions to build that. Now if these folks could code well they would probably also build out unit tests. Thus reducing the need for manual labor testing the site, logic etc and launching faster.

DougWebb 13y ago
SURESH PALDIA: a) Shouldn't be so proud of himself, and b) Should learn to use Version Control, which does a fine job of keeping track of who wrote what.
dopamean 13y ago
I really don't understand these statements. I agree that the code isn't particularly elegant and violates some best practices but who else should have written it? I see so many comments be it here or Reddit or anywhere really from know it all criticizing work people have done. If it's so easy for it to have been done the way you say then why does it never seem to be done that way. It seems that the devs available to build these projects for the government aren't the best ones. The best ones must be at Facebook refactoring the Poke code.
- ilyanep 13y ago
  > It seems that the devs available to build these projects for the government aren't the best ones. The best ones must be at Facebook refactoring the Poke code. There are lots of companies on Silicon Valley writing great code that are doing things a lot more important than Facebook pokes.
- semerda 13y ago
  The reason you are seeing so many comments criticizing the work done on these government sites is due to the mountain of money spent on offshore outsourcing to deliver rubbish quality. A grad/junior software engineer in Silicon Valley could produce better quality code. Everyone is an expert until they have to deliver something!

by semerda 13y ago

DougWebb 13y ago

SURESH PALDIA: a) Shouldn't be so proud of himself, and b) Should learn to use Version Control, which does a fine job of keeping track of who wrote what.

dopamean 13y ago

I really don't understand these statements. I agree that the code isn't particularly elegant and violates some best practices but who else should have written it? I see so many comments be it here or Reddit or anywhere really from know it all criticizing work people have done. If it's so easy for it to have been done the way you say then why does it never seem to be done that way. It seems that the devs available to build these projects for the government aren't the best ones. The best ones must be at Facebook refactoring the Poke code.

ilyanep 13y ago
> It seems that the devs available to build these projects for the government aren't the best ones. The best ones must be at Facebook refactoring the Poke code. There are lots of companies on Silicon Valley writing great code that are doing things a lot more important than Facebook pokes.
semerda 13y ago
The reason you are seeing so many comments criticizing the work done on these government sites is due to the mountain of money spent on offshore outsourcing to deliver rubbish quality. A grad/junior software engineer in Silicon Valley could produce better quality code. Everyone is an expert until they have to deliver something!