3 ms·
I don't really agree. They made all the effort to put CSRF tokens everywhere, and the vast majority are properly validated, but here there was probably some bug
by meowface 13y ago
I don't really agree. They made all the effort to put CSRF tokens everywhere, and the vast majority are properly validated, but here there was probably some bug where they assumed the CSRF token validation check was always running, but I guess it wasn't.
It's certainly a mistake, but it was probably easy for developers and QA to miss.
- deleted 13y ago[deleted]
- memoryfault 13y agoI disagree with that. It's a get request that is changing state server-side. That is a dead giveaway for a CSRF vulnerability.
- debt 13y agoThey didn't validate the token nor did they make sure the user id was valid for the request; that's two important checks that either weren't there or failed. Seems like they just weren't there as there would have been more failures like this throughout the site. Because those checks weren't there I'd say it was an amateur mistake. Again, if this is the case then the engineer just made an assumption that this request can only be made in particular user state.