3 ms·
This is not horrible. The architecture is pretty decent, and it seems a lot of thought went into categorizing the different aspects of the library. I, especiall
by russelluresti 13y ago
This is not horrible. The architecture is pretty decent, and it seems a lot of thought went into categorizing the different aspects of the library. I, especially, like how each item is broken down into types, groups, states, and variation.
The UI makes some interesting choices, but I'm sure this could be skinned with a bit of elbow grease.
I'd say my only real complaint is the validation on forms - it seems specifically inefficient to declare an object in JS and pass in each form field and set it's rule as "empty". I would consider utilizing a data attribute and doing something like data-validate="empty". You could even accept a list of them with something like "data-validate="empty email" etc. The only downside would be figuring out a way to still accept custom messages - something like data-message="Please enter your first name." would be fine for one validation check, but passing in a multiple messages for multiple validation rules would get ugly fast.