3 ms·
If you've got a robust tests and continuous integration setup to automatically test pull requests [1], why not? [1] https://github.com/blog/1227-commit-status-
by tlrobinson 13y ago
If you've got a robust tests and continuous integration setup to automatically test pull requests [1], why not?
[1] https://github.com/blog/1227-commit-status-api https://github.com/blog/1227-commit-status-api
- jlgreco 13y agoBecause not all code that passes the tests is acceptable? I don't know about you, but I still read code during code reviews, I don't just check to make sure the tests all passed.
- tlrobinson 13y agoAnd what's stopping you from reading code on a mobile device?
- jlgreco 13y agoEffectively? The fact that it is a mobile device. You can do it, but it is anything but ideal and people are prone to take shortcuts, particularly when something inconvenient and based on the 'honor system' appears. I'm trying to think of a good analogy here... "It is like allowing people to use 'water wings' and pool noodles in the deep end of a pool", if that makes any sense.