4 ms·

Merge Pull Requests from your phone

27 points by geetarista 13y ago

chancancode 13y ago
I'm not too sure if this is intended to bring the number of open issues up or down...
dlinder 13y ago
Next up: text "MERGE" to #448482
- pkrumins 13y ago
  haha!
seppo0010 13y ago
Please don't.
jlgreco 13y ago
So I guess the idea of testing changes yourself before accepting a pull request is out the window... Sure, for some changes this may be fine ("TRIVIAL: fix typo"), but it seems to me this sort of thing will only encourage sloppy work.
- jared314 13y ago
  In some workflows, accepting a pull request is a formality. The work has already been tested and reviewed on a different branch, or is tested using CI servers that integrate with GitHub, like Travis CI or Circle CI.
- tlrobinson 13y ago
  If you've got a robust tests and continuous integration setup to automatically test pull requests [1], why not? [1] https://github.com/blog/1227-commit-status-api https://github.com/blog/1227-commit-status-api
  - jlgreco 13y ago
    Because not all code that passes the tests is acceptable? I don't know about you, but I still read code during code reviews, I don't just check to make sure the tests all passed.
    - tlrobinson 13y ago
      And what's stopping you from reading code on a mobile device?
      - jlgreco 13y ago
        Effectively? The fact that it is a mobile device. You can do it, but it is anything but ideal and people are prone to take shortcuts, particularly when something inconvenient and based on the 'honor system' appears. I'm trying to think of a good analogy here... "It is like allowing people to use 'water wings' and pool noodles in the deep end of a pool", if that makes any sense.
- dwwoelfel 13y ago
  >> So I guess the idea of testing changes yourself before accepting a pull request is out the window... In many cases, the person who merges the pull request is the person who created the pull request. The author will create a pull request, let his collaborators review the code, then hit merge once he gets a "LGTM". Presumably, the author has already tested his changes.
  - jlgreco 13y ago
    Well that is fine, as I said there are some situations where this would work fine, I am concerned about the other use cases though.
jacquesc 13y ago
Seems like they still have to reimplement a ton of their features on the mobile views. I've just been using "use desktop mode" in mobile chrome and that allows me to do everything.
jgalt212 13y ago
Clearly a good use of Andreessen Horowitz's $100MM.

27 points by geetarista 13y ago

chancancode 13y ago

I'm not too sure if this is intended to bring the number of open issues up or down...

dlinder 13y ago

Next up: text "MERGE" to #448482

pkrumins 13y ago
haha!

seppo0010 13y ago

Please don't.

jlgreco 13y ago

So I guess the idea of testing changes yourself before accepting a pull request is out the window... Sure, for some changes this may be fine ("TRIVIAL: fix typo"), but it seems to me this sort of thing will only encourage sloppy work.

jared314 13y ago
In some workflows, accepting a pull request is a formality. The work has already been tested and reviewed on a different branch, or is tested using CI servers that integrate with GitHub, like Travis CI or Circle CI.
tlrobinson 13y ago
If you've got a robust tests and continuous integration setup to automatically test pull requests [1], why not? [1] https://github.com/blog/1227-commit-status-api https://github.com/blog/1227-commit-status-api
- jlgreco 13y ago
  Because not all code that passes the tests is acceptable? I don't know about you, but I still read code during code reviews, I don't just check to make sure the tests all passed.
  - tlrobinson 13y ago
    And what's stopping you from reading code on a mobile device?
    - jlgreco 13y ago
      Effectively? The fact that it is a mobile device. You can do it, but it is anything but ideal and people are prone to take shortcuts, particularly when something inconvenient and based on the 'honor system' appears. I'm trying to think of a good analogy here... "It is like allowing people to use 'water wings' and pool noodles in the deep end of a pool", if that makes any sense.
dwwoelfel 13y ago
>> So I guess the idea of testing changes yourself before accepting a pull request is out the window... In many cases, the person who merges the pull request is the person who created the pull request. The author will create a pull request, let his collaborators review the code, then hit merge once he gets a "LGTM". Presumably, the author has already tested his changes.
- jlgreco 13y ago
  Well that is fine, as I said there are some situations where this would work fine, I am concerned about the other use cases though.

jacquesc 13y ago

Seems like they still have to reimplement a ton of their features on the mobile views. I've just been using "use desktop mode" in mobile chrome and that allows me to do everything.

jgalt212 13y ago

Clearly a good use of Andreessen Horowitz's $100MM.