3 ms·
Sorry, just broke your regex. hello@visit.melbourne. Yes, that's a valid TLD now.
by nwh 13y ago
Sorry, just broke your regex.
hello@visit.melbourne.
Yes, that's a valid TLD now.
- huhtenberg 13y agoNo, it's not - http://en.wikipedia.org/wiki/List_of_Internet_top-level_domains http://en.wikipedia.org/wiki/List_of_Internet_top-level_doma... If you are referring to {2,6}, then it's easy to adjust once longer domains are put to actual use. If you are referring to the trailing dot, then that's exactly what I was saying - practically, email formats that are used by real people is a much simpler subset of what's permitted by the spec.
- nwh 13y agoYes, it is, or at least close enough that you should be considering it. http://newgtlds.icann.org/sites/default/files/ier/hu62oef5uc0u8riu78usp26r/ie-1-1918-10194-en.pdf http://newgtlds.icann.org/sites/default/files/ier/hu62oef5uc... gTLD can also contain punnycode/unicode now, which additionally breaks your regex in another way.
- huhtenberg 13y ago"Close enough" doesn't count :)
- nwh 13y agoIt does for all the irritated people that can't use their new domains on the tens of thousands of systems with rigid regex like this. Even if it's not breaking anything today, it's certain it will in the future.
- huhtenberg 13y agoIt "doesn't count" for melborne TLD that currently sits in the "Initial Preapproval" state. -- But more generally, you just don't want to hear what I'm saying. Right now, people do NOT use email addresses with internationalized domains, they do NOT put trailing periods in domain names, etc. Once they start doing that, the regex can be adjusted to accommodate for that on first false rejection. As it exists now, the regex is tailored exactly to how emails are used now, by real humans. A negative is an indication of a bot activity or some other oddity that needs attention. Feel free to support that transparently, but the question is why would you want to do that.
- vidarh 13y ago> for that on first false rejection. This assumes that you manually verify every rejection, or that they contact you. In other words: Either you're not using this anywhere with volume that matters, or you don't know that it hasn't caught false negatives. > A negative is an indication of a bot activity or some other oddity that needs attention High volume of negatives is an indication of bot activity or some other oddity. A single or handful of negatives is just humans going about their business as horrible typists. If your volume is small enough that you can treat every negative as something to investigate, you really have no basis for saying anything about how well your regex works.
- huhtenberg 13y agoIt's not the Gmail-level volume, but it's an email per day either. And yet there is still very few negatives, so it is possible to go through them by hand. Vast majority falls into "fafafa" and "test@test" category. The remainder is typos, e.g. commas instead of periods.
- ronaldx 13y ago> A negative is an indication of a bot activity or some other oddity that needs attention. Feel free to support that transparently, but the question is why would you want to do that. Why?: It's very bad UX to say to a human "we don't support you because we think you just might be a bot".
- nwh 13y agoI did actually use an interesting domain for a little while, but got completely fed up of it being rejected everywhere.
- temac 13y agoWhy do you want so much to limit to 6, especially since you also do a DNS validation? You should better lean on the permissive side; that would be one less thing to think about. That kind of "validation" does not check for existing email addresses anyway, so there is not much value in trying to be strict in this area.
- huhtenberg 13y agoYeah, I agree in principle, but it's at 6 simply because it works fine as is. Given new developments it might make sense to bump it up and/or add support for punycode, and we'll do it once it's actually needed.
- kijeda 13y agoWhat is the threshold where supporting a domain becomes important? It seems awfully arbitrary to say it "works fine as is" when it is disenfranchising millions of registered domains as it stands.
- nly 13y agoForget new gTLDs, the current ones are tricky enough: http://publicsuffix.org/ http://publicsuffix.org/