4 ms·
//All code had to be reviewed before it was checked into the team's version control software.// Their first rule above is based on how incompetent their RTC too
by pramalin 13y ago
//All code had to be reviewed before it was checked into the team's version control software.//
Their first rule above is based on how incompetent their RTC tool sets are. I wouldn't say this is a best practice.
- pramalin 13y agoI would elaborate that, a version control system must assist in code review process by allowing to version control the unverified/reviewed code also in private branches. With RTC, it is hard enough to review the change history in trunk and its capabilities pale in comparison with say Tortoise SVN. That's why I feel that their first rule of their study is based on the shortcomings in RTC's jazz version control system. However the code review best practices came out of the study are solid. However they do not touch upon the version control practices.
- jacobparker 13y agoSorry for down-voting your original post, I misunderstood. Your clarification makes sense and I agree.
- tomjen3 13y agoYeah that isn't a good thing, because by the time your code is reviewed it would no longer compiler as others have made changes in the code too.