4 ms·
Agreed about abbreviations. To distinguish "text_body" and "html_body", what about simply "text" and "html"? That's what we use internally. Also, how does one
by benhoyt 13y ago
Agreed about abbreviations.
To distinguish "text_body" and "html_body", what about simply "text" and "html"? That's what we use internally.
Also, how does one send To: multiple addresses with this library? I think it'd be good if to_address could be a list (or their was a separate to_addresses, which could be a list).
I like it how cc_addrs / bcc_addrs can be a list already, of either addresses or (email, name) tuples. Why not do the same thing from from_address and to_addresses, and get rid of from_name and to_name?
- ianstormtaylor 13y agoHonestly I didn't even see the "cc_addrs" and "bcc_addrs". Those are horrible. Now you have complex abbreviations that are pluralized! I completely agree. And while we're making them accept lists or tuples, change their names to: "to", "from", "cc" and "bcc". Very clear and still a tiny amount of characters.
- fsniper 13y agothat's what I was thinking of. Accepting dicts or tuples would be ok. Even just using [ "Name <email address>", "name <email address>"] would be more human.
- tomekwojcik 13y agoNote that, for CC and BCC addresses, there's a number of accepted formats. Consult docs for more info: http://tomekwojcik.github.io/envelopes/api/envelope.html http://tomekwojcik.github.io/envelopes/api/envelope.html
- fsniper 13y agoI'm talking about to field also.