3 ms·

That implies that it's ok. I would prefer: "Hey john, thanks for the contribution though, but it's not good enough - it's currently too slow and hogs too much m

by 14113 13y ago

That implies that it's ok. I would prefer: "Hey john, thanks for the contribution though, but it's not good enough - it's currently too slow and hogs too much memory. As an example of how it should be running see sarah's Y."

codyb 13y ago
That would be the case I suppose if John's entire contribution was poor. I was thinking perhaps there might be some part of John's contribution that was actually quality and to say "hey, you know you're doing good work, it's just this part that isn't working well". Obviously we're dealing in hypotheticals here and I guess if it is the case that none of John's code works well then your approach is probably the only decent approach. If there is some code of John's that does work well than I find a lot of times it's easier to give a little compliment prior to your criticism just so they know that yes, we do appreciate your work and contributions, but in order to be more effective here is what you have to do.
andyjohnson0 13y ago
Have you ever managed or lead a team? If you have, you'll know that your job in that situation is to get the best results from the team - over a variety of time-scales. Sometimes you have to crack the whip, but mostly its important to be somewhat diplomatic and respectful while still being clear and direct, because the team is made of people who (unless it has some kind of dysfunctional brogramming-type culture) have a need for fulfilment in the work they're doing. Some cultures are more direct (eg. Dutch, Israeli, Finnish) than others (eg. Japan). If everyone on a team expects the same norms then they are going to get along well. The problem for Linus is that the "team" is a pan-cultural community with a spread of norms and (it seems to me) that Linus want to be the Linux benevolent-dictator-for-life while everyone else expects him to be a leader.

by 14113 13y ago

codyb 13y ago

That would be the case I suppose if John's entire contribution was poor. I was thinking perhaps there might be some part of John's contribution that was actually quality and to say "hey, you know you're doing good work, it's just this part that isn't working well". Obviously we're dealing in hypotheticals here and I guess if it is the case that none of John's code works well then your approach is probably the only decent approach. If there is some code of John's that does work well than I find a lot of times it's easier to give a little compliment prior to your criticism just so they know that yes, we do appreciate your work and contributions, but in order to be more effective here is what you have to do.

andyjohnson0 13y ago

Have you ever managed or lead a team? If you have, you'll know that your job in that situation is to get the best results from the team - over a variety of time-scales. Sometimes you have to crack the whip, but mostly its important to be somewhat diplomatic and respectful while still being clear and direct, because the team is made of people who (unless it has some kind of dysfunctional brogramming-type culture) have a need for fulfilment in the work they're doing. Some cultures are more direct (eg. Dutch, Israeli, Finnish) than others (eg. Japan). If everyone on a team expects the same norms then they are going to get along well. The problem for Linus is that the "team" is a pan-cultural community with a spread of norms and (it seems to me) that Linus want to be the Linux benevolent-dictator-for-life while everyone else expects him to be a leader.