5 ms·

I have to agree. The fact that you still cannot do side by side diffs on pull requests makes it a less than useful code review tool.

by Newky 13y ago

gcr 13y ago
What's the difference between a diff and a side-by-side view of two files? I'd (usually) prefer the former.
- swang 13y ago
  It is difficult to follow the code that's been added when all the deletions/diffs get in the way.
  - sdesol 13y ago
    I agree. I find that unified diffs work well 90% of the time but when it doesn't it can be crippling. I've attached some screenshots at http://screenshots.gitsense.com/index.html http://screenshots.gitsense.com/index.html that illustrates where side by side becomes a requirement for me. Yeah I can make sense of things with a unified view but the side by side really makes things more obvious. Note you can find this diff at github at https://github.com/joyent/node/pull/5615/files#L0L80 https://github.com/joyent/node/pull/5615/files#L0L80
    - jervisfm 13y ago
      What program or tool were you using to see the diffs side by side ?
      - sdesol 13y ago
        It's from my tool that I've been developing. You can see how the diffing works at https://www.youtube.com/watch?v=fi7GvcW1NKA https://www.youtube.com/watch?v=fi7GvcW1NKA Unfortunately I don't show you how to switch to the side by side view. To do this, you just click on the view toggle button at the top left corner of the diff window.
        gcr 13y ago
        Nice Work! That sounds similar to Meld. http://meldmerge.org/ http://meldmerge.org/
- ngoldbaum 13y ago
  Take a look at a pull request on bitbucket. Like this one: https://bitbucket.org/birkenfeld/sphinx/pull-request/146/resolve-issue-1172-dont-divide-by-zero/diff https://bitbucket.org/birkenfeld/sphinx/pull-request/146/res... Click 'Side-by-Side Diff'. Github has a lot going for it, but bitbucket is the clear UX win as far as reviewing pull requests goes.

5 ms·

I have to agree. The fact that you still cannot do side by side diffs on pull requests makes it a less than useful code review tool.

by Newky 13y ago

I have to agree. The fact that you still cannot do side by side diffs on pull requests makes it a less than useful code review tool.

gcr 13y ago
What's the difference between a diff and a side-by-side view of two files? I'd (usually) prefer the former.
- swang 13y ago
  It is difficult to follow the code that's been added when all the deletions/diffs get in the way.
  - sdesol 13y ago
    I agree. I find that unified diffs work well 90% of the time but when it doesn't it can be crippling. I've attached some screenshots at http://screenshots.gitsense.com/index.html http://screenshots.gitsense.com/index.html that illustrates where side by side becomes a requirement for me. Yeah I can make sense of things with a unified view but the side by side really makes things more obvious. Note you can find this diff at github at https://github.com/joyent/node/pull/5615/files#L0L80 https://github.com/joyent/node/pull/5615/files#L0L80
    - jervisfm 13y ago
      What program or tool were you using to see the diffs side by side ?
      - sdesol 13y ago
        It's from my tool that I've been developing. You can see how the diffing works at https://www.youtube.com/watch?v=fi7GvcW1NKA https://www.youtube.com/watch?v=fi7GvcW1NKA Unfortunately I don't show you how to switch to the side by side view. To do this, you just click on the view toggle button at the top left corner of the diff window.
        gcr 13y ago
        Nice Work! That sounds similar to Meld. http://meldmerge.org/ http://meldmerge.org/
- ngoldbaum 13y ago
  Take a look at a pull request on bitbucket. Like this one: https://bitbucket.org/birkenfeld/sphinx/pull-request/146/resolve-issue-1172-dont-divide-by-zero/diff https://bitbucket.org/birkenfeld/sphinx/pull-request/146/res... Click 'Side-by-Side Diff'. Github has a lot going for it, but bitbucket is the clear UX win as far as reviewing pull requests goes.