4 ms·
Only works when you have push access to the repository that is the source of the PR. Normally maintainers don't have access to the repositories for all contrib
by jedbrown 13y ago
Only works when you have push access to the repository that is the source of the PR. Normally maintainers don't have access to the repositories for all contributors.
- plorkyeran 13y agoEr, no? You merge the unfixed version via the web UI (to get the PR marked as merged), then immediately force-push the fixed version to your own repo, not their's.
- jedbrown 13y agoOh, I thought you meant updating the pull request by force-pushing on their branch. Your solution is racy, thus only acceptable for projects small enough that the likelihood of someone pulling during that window is sufficiently low.
- plorkyeran 13y agoIt's definitely not an option for very large projects, but projects small enough to have a very low chance of someone pulling in a several second window describes the vast majority of projects (and in general by the time it gets unsafe I'd expect fixing up incoming pull requests to be impractical time-wise anyway).