3 ms·
I don't get it, it seems to me that this fix is incorrect. It's pointless to check for such a signed integer overflow after it happened.
by unix-junkie 13y ago
I don't get it, it seems to me that this fix is incorrect.
It's pointless to check for such a signed integer overflow after it happened.
- lysium 13y agoWhy is length stored with a signed integer in the first place?
- tptacek 13y agoIt's (mis)using off_t, which allows for negative offsets (for obvious reasons). You also don't need signed integers to have integer overflows.
- bcoates 13y agoI think you're right, unless nginx uses --fwrapv or it's equivalent on every compiler.