4 ms·
Maybe I'm getting it wrong, but this comment seems so arrogant.. and with ngninx, that has one of the cleanest code bases of open source software actually used
by alcuadrado 13y ago
Maybe I'm getting it wrong, but this comment seems so arrogant.. and with ngninx, that has one of the cleanest code bases of open source software actually used by many people :s
- zzzcpan 13y agoIt doesn't look arrogant to me. And it doesn't matter how clean the code looks like if it uses trillions of mutable states, lots of inconsistent interfaces, occasional pointer arithmetics, manual memory management, gotos all over the place and no module tests whatsoever. I'd say nginx is a pretty error prone piece of software, just like most of the software written in C.
- nkozyra 13y agoWait, "most of the software written in C" is "pretty error prone?" That's a pretty big statement right there.
- ihaveajob 13y agoIMO, "most of the software written in any language" would be a good fit for that sentence.
- paraboul 13y agoSorry but that's a really stupid comment. You are just saying that C is not clean. (IMHO) nginx code-base is doing a really good job dealing with micro-optimization. >code looks like if it uses trillions of mutable state Actually, that's a very good approach. e.g. : nginx parser get optimized out as a big jump table (http://en.wikipedia.org/wiki/Branch_table http://en.wikipedia.org/wiki/Branch_table)
- zzzcpan 13y agoI didn't mean nginx parser and state machines in general as mutable states, but rather state changes in variables across multiple functions and files. They are impossible to keep track of and nginx is full of them.
- aw3c2 13y agoTo me "no functional changes" just means that the commit does not mean to introduce/change any functionality, for example if you refactor code or clean up.