3 ms·
There are "feature branches", and there are "patch sets with four patches and three merge commits that are there just because the submitter did a bunch of pulls
by ajross 14y ago
There are "feature branches", and there are "patch sets with four patches and three merge commits that are there just because the submitter did a bunch of pulls while working on it."
If you're dealing with a large code base with many submitters, you have to demand that individual submissions apply cleanly. That is isomorphic to demanding that they be rebased.
- jcrites 14y agoI am personally a proponent of rebasing, but I'm reading through the recent Hacker News threads to get a sense of the arguments on both sides. > If you're dealing with a large code base with many submitters, you have to demand that individual submissions apply cleanly. That is isomorphic to demanding that they be rebased. To play devil's advocate for the merge perspective: wouldn't this also be achieved if the commit author had merged master into his branch first before submitting? It will apply cleanly because conflicts were fixed during the merge, rather than because it was rebased.