3 ms·
Pull requests can take more time to process than feature requests, because 1) The code is usually inconsistent with the rest of the project, 2) there are often
by juanbyrge 14y ago
Pull requests can take more time to process than feature requests, because 1) The code is usually inconsistent with the rest of the project, 2) there are often merge conflicts that the submitter has to resolve 3) people rarely write tests or documentation about the feature.
- skore 14y agoYou make good points, but each of these is solvable: 1) Require the code to be consistent. Tell the submitter how to do this. 2) Merges have to be straight forward, or you don't accept the submission. I think Linus Torvalds has the same strategy for the kernel - you figure out the merge, I'll accept it. 3) That depends a lot on how you set up your tests and documentation. If you make it simple to write both, it's simple to require them. If they're not simple, you should make them.