4 ms·

The library code made me sick. Look at all the globals and where is the indentation and organization? http://ie6-upgrade-warning.googlecode.com/svn/trunk/ie6/wa

by Sephr 18y ago

The library code made me sick. Look at all the globals and where is the indentation and organization? http://ie6-upgrade-warning.googlecode.com/svn/trunk/ie6/warning.js http://ie6-upgrade-warning.googlecode.com/svn/trunk/ie6/warn... Edit: Wow, the main function, e, (great name, definitely not going to collide with other names) has >50 var statements. I don't think the guy who made this library knows that you can var a, b, c, d;

thorax 18y ago
Maybe open up a bug report? http://code.google.com/p/ie6-upgrade-warning/issues/entry http://code.google.com/p/ie6-upgrade-warning/issues/entry From the looks of it, the author is a junior coder or new to this sort of JS library code. He may not know any better, but keep in mind he's just looking to help by releasing this-- we were all newbie devs at one point. Overall, I'm not a fan of disparaging any code people release for free. There are too many developers who keep useful code locked away on their disks because they're afraid people will mock their work. Don't get me wrong, it's very helpful for potential consumers to know about the issues you mention, but there may be a better way to phrase your criticism.
- Sephr 18y ago
  Sorry for coming off so rude. Anyway, I was just going to send a message offering it up for the author due to it not being that large of a codebase and was going to offer to make neater version of the code. I'm going instead to send a bug report as you suggested as that seems best for tracking it.