4 ms·
That is a fantastic commit message. I try and convince anyone I work with that they should write commit messages like this. Slowly, but surely, they come around
by themckman 14y ago
That is a fantastic commit message. I try and convince anyone I work with that they should write commit messages like this. Slowly, but surely, they come around.
- sickpig 14y agoAnd the author is a fantastic coder/developer, really! https://en.wikipedia.org/wiki/Tom_Lane_%28computer_scientist%29 https://en.wikipedia.org/wiki/Tom_Lane_%28computer_scientist...
- joevandyk 14y agoTom committed the fix, he didn't author it.
- weaksauce 14y agoThe author of the commit message I think is what the op was implying.
- sickpig 14y agoYep this is what I meant. I could have chosen my words in a better way though, since we were talking about a git commit. Having said that quoting commit message 2nd last paragraph: The Postgres project thanks Mitsumasa Kondo for discovering this bug, Kyotaro Horiguchi for drafting the fix, and Noah Misch for recognizing the full extent of the danger. We can't exclude without further info that Tom contributed to the fix, just saying. Knowing him after a few years spent following postgres dev process I bet on co-authoring at least :)
- mkopinsky 14y agoWho writes commit messages for these kinds of user-submitted patches? The author or the committer?
- jeltz 14y agoUsually the committer. Most patches sent to the mailing list does not contain a commit message.
- selenamarie 14y agoGenerally the committer writes the commit message. There is occassionally discussion of specific wording ahead of time.
- drbawb 14y agoWhat gets me about Tom Lane is that he's _so active_ on the mailing list(s). It seems that every time I search the archives regarding an issue I'm having: I find a reply authored by Tom Lane.