3 ms·
IMO any overly clever code would remind of obfuscation. The trick is to notice in time your own attempts at being smart and refrain. Thus the code could communi
by goblin89 14y ago
IMO any overly clever code would remind of obfuscation. The trick is to notice in time your own attempts at being smart and refrain. Thus the code could communicate most of the things that needed to be explained in this walkthrough.
That's also why I personally am not very enthusiastic about such code reviews. Good code would seem boring, and why study bad code?
- atomical 14y agoSo you become a better programmer?
- goblin89 14y agoFair enough, maybe it would work for someone. I find that reading and especially writing code of certain style shapes my style accordingly, similar to how our environment influences us, so I'd rather learn by working with good code—but it's just me.
- atomical 14y agoCode reviews are about finding (1) the proper way to do things (2) edge cases, bugs, and the right architecture. Code reviews are not academic at all. They do require someone with a lot of experience.
- pekk 14y agoAren't code reviews normally meant to highlight which parts are good and which are bad?
- goblin89 14y agoNot in this case, though—OP just explains what does the code do, without any opinion.