3 ms·
peer code reviews. I don't they are done often enough. But, as a developer, if I'm sitting writing a line of code, and I know my peers are soon going to review
by dave_sid 14y ago
peer code reviews. I don't they are done often enough. But, as a developer, if I'm sitting writing a line of code, and I know my peers are soon going to review it, I'd be less likely to cut corners and make myself look unprofessional.
- Evbn 14y agoIn my experience, peer reviews backfire when they veer into style territory: they generate hours of non-productive work, paid by the reviewed, to generate output that has no value to the customer or management. I used to take style comments from reviewers seriously, until I saw the code they had submitted that got them promoted.
- rohitnair 14y agoIn my experience, even reviews suffer when you're working against a deadline to ship. Reviewers add comments, but major refactoring is usually marked with a "can do this post launch" (which, of course, never gets done) or people just ignore them and check-in any way (unless they comments are related to actual functionality).