3 ms·
Hi Sytse, Just for future reference: Its common courtesy to give attributions next to contributed changes in the changelog. I gladly sponsored development of
by Argorak 14y ago
Hi Sytse,
Just for future reference:
Its common courtesy to give attributions next to contributed changes in the changelog. I gladly sponsored development of one of them (API: improved return codes and docs, https://github.com/gitlabhq/gitlabhq/pull/2835 https://github.com/gitlabhq/gitlabhq/pull/2835) and a short nod to the involved persons would be nice.
Keep up the good work, thank you!
- sytse 14y agoHi Arhorak, Thank you for the reference. I think attributing the authors is a good idea. I've created https://github.com/gitlabhq/gitlabhq/pull/3303 https://github.com/gitlabhq/gitlabhq/pull/3303 What do you think? Is it ok to attribute to the full name? Best regards, Sytse
- Argorak 14y agoHi, in the Padrino project, we usually attribute by (GH) nickname, because thats what most programmers build their identity around. Also, all involved are mentioned. In that case, it would be: - API: improved return codes and docs. (Xylakant, justahero) See ours: https://github.com/padrino/padrino-framework/blob/master/CHANGES.rdoc https://github.com/padrino/padrino-framework/blob/master/CHA...
- sytse 14y agoGood points. I've added Sebastian Ziebell. About mentioning usernames, I figured it might get a bit confusing when we get public projects on GitLab.com, you would have to guess which platform the username belongs to. What do you think?
- sytse 14y agoThanks for understanding in https://github.com/gitlabhq/gitlabhq/pull/3303#discussion_r3493319 https://github.com/gitlabhq/gitlabhq/pull/3303#discussion_r3... The attribution was merged and is live on https://github.com/gitlabhq/gitlabhq/blob/master/CHANGELOG#L27 https://github.com/gitlabhq/gitlabhq/blob/master/CHANGELOG#L...
- Argorak 14y agoAnd thanks to you from our side :)!