3 ms·

Storehaus from Twitter

37 points by sritchie 14y ago

hcarvalhoalves 14y ago
"Storehaus is built on top of Twitter's Future." I go check what it is, and find this WTF (line 158 and on): https://github.com/twitter/util/blob/master/util-core/src/main/scala/com/twitter/util/Future.scala#L158 https://github.com/twitter/util/blob/master/util-core/src/ma...
- octo_t 14y ago
  Auto-generated code ftw! Pretty sure twitter also used to have the same thing for time conversions as well.
- fizx 14y ago
  Scala has Tuples, so you can declare: val t = ("hello", 42) You guys should love this! It makes something Java-compatible (a Tuple2<String, Integer>), while being a bazillion times less verbose. The price for doing this in the JVM with reasonable Java-compatibility is that Tuple2<A,B> is a different class than Tuple3<A,B,C> than Tuple4<A,B,C,D>. Tuple goes to 22. Collections-like frameworks dealing with Tuples often have to generate versions of methods that operate on one of each version of tuple, which is why you see 22 methods here, one to generate each version. As much as I think scala is a little kitchen sink already, and macros are yet another feature I don't think people need in scala, they'd be useful to generate this code pattern.
- ryangreenberg 14y ago
  The 22 overloaded versions of Future#join is a consequence of wanting to supporting all the possible method calls. It goes up to 22 because that is the limit to possible number of arguments in Scala. See, for example, the corresponding Function22 (https://github.com/scala/scala/blob/master/src/library/scala/Function22.scala https://github.com/scala/scala/blob/master/src/library/scala...) and Tuple22 case class (https://github.com/scala/scala/blob/master/src/library/scala/Tuple22.scala https://github.com/scala/scala/blob/master/src/library/scala...) from the Scala source. You can't just use a catch-all argument like xs: Future* because you have to parameterize the types of the arguments.

3 ms·

Storehaus from Twitter

37 points by sritchie 14y ago

hcarvalhoalves 14y ago
"Storehaus is built on top of Twitter's Future." I go check what it is, and find this WTF (line 158 and on): https://github.com/twitter/util/blob/master/util-core/src/main/scala/com/twitter/util/Future.scala#L158 https://github.com/twitter/util/blob/master/util-core/src/ma...
- octo_t 14y ago
  Auto-generated code ftw! Pretty sure twitter also used to have the same thing for time conversions as well.
- fizx 14y ago
  Scala has Tuples, so you can declare: val t = ("hello", 42) You guys should love this! It makes something Java-compatible (a Tuple2<String, Integer>), while being a bazillion times less verbose. The price for doing this in the JVM with reasonable Java-compatibility is that Tuple2<A,B> is a different class than Tuple3<A,B,C> than Tuple4<A,B,C,D>. Tuple goes to 22. Collections-like frameworks dealing with Tuples often have to generate versions of methods that operate on one of each version of tuple, which is why you see 22 methods here, one to generate each version. As much as I think scala is a little kitchen sink already, and macros are yet another feature I don't think people need in scala, they'd be useful to generate this code pattern.
- ryangreenberg 14y ago
  The 22 overloaded versions of Future#join is a consequence of wanting to supporting all the possible method calls. It goes up to 22 because that is the limit to possible number of arguments in Scala. See, for example, the corresponding Function22 (https://github.com/scala/scala/blob/master/src/library/scala/Function22.scala https://github.com/scala/scala/blob/master/src/library/scala...) and Tuple22 case class (https://github.com/scala/scala/blob/master/src/library/scala/Tuple22.scala https://github.com/scala/scala/blob/master/src/library/scala...) from the Scala source. You can't just use a catch-all argument like xs: Future* because you have to parameterize the types of the arguments.