3 ms·
My point was more that I would wager most "auto styler" tools will change code that is in the kernel. You are really just bringing up more of what I consider "
by taeric 14y ago
My point was more that I would wager most "auto styler" tools will change code that is in the kernel. You are really just bringing up more of what I consider "straw men" in this argument. Terribly formatted code is of course terrible. Much of what folks argue about being "good code" is just nitpicky wastes of time. Take this snippet from the kernel:
if (pages) {
pages[i] = virt_to_page(start);
if (pages[i])
page_cache_get(pages[i]);
}
if (vmas)
vmas[i] = vma;
This is just an arbitrary snippet, as I really have no familiarity with the code. But, alone in this snippet I already see at least two things that would make most format obsessed people go stupid. (Three in the actual code, but I don't know if the tabs will be visible to folks on this forum.)
Edit: I forgot to add that I realize this segment actually conforms to the linux style guide. So... yeah, doesn't really say much other than to show that the kernel crew disagrees with most anyone you will ever hear online. It does not take too much effort to find snippets that actually do violate their own rules.