13 ms·
I get the impression he was not expecting that pull request to get merged. This was silly, but not malicious. He wasn't trying to delete home directories to pro
by philh 14y ago
I get the impression he was not expecting that pull request to get merged. This was silly, but not malicious. He wasn't trying to delete home directories to prove a point: the point he was making was directed at the repo owner.
Meanwhile, merging that pull request seems downright stupid, but maybe there are mitigating factors I'm not aware of?
- mpyne 14y agoDon't issue pull requests that you don't want merged. It's really that simple. The maintainer could easily merge it by accident by absentmindedly clicking the button they normally click in response to well-formed pull requests while thinking they'd rejected it. Maybe they have a cat, or a toddler, who knows? Don't put your name on stuff you don't want merged.