4 ms·
Very good detective work. However, a small suggestion, given: I’ve been working with networks for over 15 years and I’ve never seen anything like this. I doub
by wglb 14y ago
Very good detective work. However, a small suggestion, given:
I’ve been working with networks for over 15 years and I’ve never seen anything like this. I doubt I’ll ever see anything like it again.
This is a very excellent case for fuzz testing. My thinking is that you want to whip up your Ruby and your EventMachine and Redis going and run a constant fuzz with all sorts of packets in your pre-shipping lab.
The idea is that you want to create a condition where you do see it, and the other handful of lockups that are there that you haven't yet seen.
- Jabbles 14y agoSurely that's the manufacturer's job. Since it's caused by a specific byte at a specific place, surely you'd only need to fuzz an average of 256 packets (of the required length) to find it... which suggests it wasn't done at all... zero...
- fusiongyro 14y agoIt is, but your clients are going to complain to you.
- deleted 14y ago[deleted]
- wglb 14y agoWell, my feeling is that if you are going to ship it, you better fuzz it. And if you are assembling something with this card, you are the manufacturer. A true fuzzing run for something like this ought to run in the tens of millions of packets.
- arnsholt 14y agoThat's assuming you know the magical position. If you need to test all positions, it's 256 to the power of the number of bytes in the message.
- DuskStar 14y agoBut couldn't you test all the positions at once, by having the entire packet be random data? Unless the packet has to be a particular length for this to happen, which I didn't notice in the article.
- wisty 14y agoOr it was done once, and the "inoculation" byte came first. There were 4 buggy bytes. 3 would crash the card. 1 would fix the card ("inoculating" it). If they only fuzzed once, or fuzzed with the same dataset (random.seed(1) // seed chosen at random), then they wouldn't catch it. Even then, it's pretty sloppy.
- laughinghan 14y agoFuzz testing would have been very unlikely to help since any byte value at that position besides ASCII 1, 2, or 3 "inoculated" the NIC from the bug. There is a very excellent case to be made for fuzz testing, but this isn't it. Given that, for all we know the relevant parties did conduct extensive fuzz testing and your condescension is misplaced.
- wglb 14y agoNo condescension is intended. Fuzz testing is often not what many folks think of in a situation like this. It wouldn't surprise me at all if there are other issues that don't depend on these exact circumstances to get something to fall over.