4 ms·
Here's Linus' opinion on Github pull requests https://github.com/torvalds/linux/pull/17#issuecomment-5654674 https://github.com/torvalds/linux/pull/17#issuecomm
by mkhattab 14y ago
Here's Linus' opinion on Github pull requests
https://github.com/torvalds/linux/pull/17#issuecomment-5654674 https://github.com/torvalds/linux/pull/17#issuecomment-56546...
I wonder how critical the HN community would have been if the exchange was with a female programmer? If you read the exchange, you'll see other commenters defending Linus' blunt responses. Linus was harsher than David or Steve, he called the pull requester a moron.
- thisone 14y agoMany people also disagree with Linus' approach to criticism and disagreement. Many people also white knight Linus. This isn't a boy/girl thing. We are an industry that often prides itself on being hurtful to people we disagree with. It's my opinion that it's possible to have a strong opinion and strength of conviction without being purposefully rude.
- shocks 14y agoLinus didn't say "This is shitty code, no.". Linus said "I don't accept GitHub pull requests for these (logical) reasons. Please use the official route to send me a pull request." This is a completely different thing to what happened here.
- deleted 14y ago[deleted]
- lewispollard 14y agoI think it's referring to the later posts in the thread, such as: "Btw, Joseph, you're a quality example of why I detest the github interface. For some reason, github has attracted people who have zero taste, don't care about commit logs, and can't be bothered. The fact that I have higher standards then makes people like you make snarky comments, thinking that you are cool. You're a moron. Linus"
- pimentel 14y agoBut in this case, Heather didn't ask those guys to use her code. They just decided to have some fun at some code totally unrelated to them. Not even explaining what's so funny. In that pull request Linus actually explains quite extensively why he doesn't accept it.
- d23 14y agoIt's also a large organization that rightly should be open to criticism for the sake of improvement, not a single programmer working on a personal project.