4 ms·
I wish the guys involved would submit pull requests to amend what they thought was so bad. It has a better educational and apologetic value. It also shows the
by jondot 14y ago
I wish the guys involved would submit pull requests to amend what they thought was so bad. It has a better educational and apologetic value.
It also shows the kind of respect people should get; if you don't like the code you're seeing on Github, improve it and submit a pull request - why not?
- jff 14y agoSubmitting pull requests is for code you actually consider worthwhile/useful. These guys didn't seem to think it even has a reason to exist, so why would they try to improve it? It'd be like saying, "Well, if you don't like my toothbrush for ducks, why don't you tell me how to improve it?"
- jondot 14y agoI meant after they have apologized. Instead of saying 'sorry' in word and that they didn't really mean it, say it in a pull request teaching the person offended something of value. Further, I think they shape of the code was referred to as 'eye bleeding'. Regardless of if you're building something worthwhile, they could have fixed the eye hurting code and explain why that is a more correct way.