4 ms·

Can an experienced JavaScript developer provide some constructive reasons as to why that code might be problematic? (e.g. Is it the eval?) Might be a good lear

Can an experienced JavaScript developer provide some constructive reasons as to why that code might be problematic? (e.g. Is it the eval?) Might be a good learning opportunity for others, too.

Domenic_S 14y ago
I don't think it had anything to do with the code. She rewrote sed in JS, which IMO provoked the response (more here http://news.ycombinator.com/item?id=5107625 http://news.ycombinator.com/item?id=5107625).
- arockwell 14y ago
  If that were true why aren't their uproars over any of these projects: https://github.com/grosser/pru https://github.com/grosser/pru https://github.com/colinta/ned https://github.com/colinta/ned https://github.com/aljungberg/pyle https://github.com/aljungberg/pyle https://github.com/zzak/gsub https://github.com/zzak/gsub https://github.com/bjfletcher/node-js-sed https://github.com/bjfletcher/node-js-sed I'm sure there are more. These are just a few I could find a few minutes. Sorry, I'm not trying to call you out here. I just have serious doubts that the criticism has anything to do with merit. In other words, I don't think it makes sense to rationalize jerky behavior :(
  - Domenic_S 14y ago
    I dunno, did the other projects get tweeted and hit the right combination of followers? Why does anything get attention/go viral?
    - arockwell 14y ago
      It's a fair question. I'm honestly confused about why this blew up in the first place.
arockwell 14y ago
I have my doubts the folks criticizing it actually read the code. Even if they have, what's the point of shitting on someone's pet project? Note that none of them actually give a reason for why the think it's bad. I think the folks criticizing are simply being bullies. I think the code is fine and the project serves a nice niche. I can never remember the syntax for sed either, so I might actually use this project. No such thing as bad press I guess :)

Can an experienced JavaScript developer provide some constructive reasons as to why that code might be problematic? (e.g. Is it the eval?) Might be a good learning opportunity for others, too.

Domenic_S 14y ago

I don't think it had anything to do with the code. She rewrote sed in JS, which IMO provoked the response (more here http://news.ycombinator.com/item?id=5107625 http://news.ycombinator.com/item?id=5107625).

arockwell 14y ago
If that were true why aren't their uproars over any of these projects: https://github.com/grosser/pru https://github.com/grosser/pru https://github.com/colinta/ned https://github.com/colinta/ned https://github.com/aljungberg/pyle https://github.com/aljungberg/pyle https://github.com/zzak/gsub https://github.com/zzak/gsub https://github.com/bjfletcher/node-js-sed https://github.com/bjfletcher/node-js-sed I'm sure there are more. These are just a few I could find a few minutes. Sorry, I'm not trying to call you out here. I just have serious doubts that the criticism has anything to do with merit. In other words, I don't think it makes sense to rationalize jerky behavior :(
- Domenic_S 14y ago
  I dunno, did the other projects get tweeted and hit the right combination of followers? Why does anything get attention/go viral?
  - arockwell 14y ago
    It's a fair question. I'm honestly confused about why this blew up in the first place.

arockwell 14y ago

I have my doubts the folks criticizing it actually read the code. Even if they have, what's the point of shitting on someone's pet project? Note that none of them actually give a reason for why the think it's bad. I think the folks criticizing are simply being bullies. I think the code is fine and the project serves a nice niche. I can never remember the syntax for sed either, so I might actually use this project. No such thing as bad press I guess :)